Re: [PATCH v3 1/1] Input: serio - Add ARC PS/2 driver

From: Joe Perches
Date: Thu Oct 18 2012 - 05:27:11 EST


On Thu, 2012-10-18 at 09:05 +0000, Mischa Jonker wrote:
> Hi Joe,
>
> >> + while (1) {
> >infinite loop with bad hardware?
> >Perhaps a jiffies timeout?
>
> What do you suggest? Add a counter and limit the maximum number of iterations to an arbitrary number (say 1000)?

Yes, something like that.
Or something like:

unsigned long timeout = jiffies + somevalue;
while (time_before(jiffies, timeout) {
etc...
}

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/