Re: [PATCH -v2 3/6] x86, RAS: Convert mce-inject module to debugfs

From: Borislav Petkov
Date: Wed Oct 17 2012 - 16:02:17 EST


On Wed, Oct 17, 2012 at 12:06:35PM -0700, Andi Kleen wrote:
> Borislav Petkov <bp@xxxxxxxxx> writes:
>
> > From: Borislav Petkov <borislav.petkov@xxxxxxx>
> >
> > This is a module which is used for debugging MCE decoding paths so its
> > userspace interface should go to debugfs, where it belongs conceptually.
> >
> > While at it, add a warning to the Kconfig text that this interface is
> > unstable and no userspace scripts should rely all too much on it.
>
> Nack. You broke mce-test/mce-inject, aka existing userland which is not
> allowed in Linux.

WTF? Have you actually even looked at the patch?

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/