Re: [PATCH V3] block/throttle: Add IO throttled information inblkio.throttle

From: Vivek Goyal
Date: Wed Oct 17 2012 - 09:49:51 EST


On Tue, Oct 16, 2012 at 04:27:06PM -0700, Tejun Heo wrote:

[..]
> > Changelog from v2:
> > Use nr-queued[] of struct throtl_grp for stats instaed of adding new blkg_rwstat.
>
> As I wrote last time, I would prefer exposing the total number queued
> to blk-throttle rather than exposing the number of bios being
> currently held and let userland calculate from the difference from
> throttle.io_serviced. That is simpler and more inline with all other
> stats.

Hi Tejun,

Can you explain a bit more. Whe do you mean by "total number queued". I
think throttle.io_queued will total number of bios queued in the cgroup
at the time of query.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/