Re: [PATCH v3] x86/mce: Honour bios-set CMCI threshold

From: Naveen N. Rao
Date: Wed Oct 17 2012 - 07:27:36 EST


On 10/17/2012 04:29 PM, Borislav Petkov wrote:

+static struct dev_ext_attribute dev_attr_bios_cmci_threshold = {
+ __ATTR(bios_cmci_threshold, 0444, device_show_int, NULL),
+ &mce_bios_cmci_threshold

Ok, I just noticed this (we must've missed it during review) but why is
this read-only? If it has to be read-only, why do we have a node for
this in sysfs instead of simply issuing the printk statements below and
people who are interested in this, can grep dmesg?

This was added so that user-space tools could find out if we're using thresholds for CMCI.

Regards,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/