Re: [PATCH 1/2] backlight: lms283gf05: use devm_gpio_request_one

[Marek Vasut]

Dear Jingoo Han,

> By using devm_gpio_request_one it is possible to set the direction
> and initial value in one shot. Thus, using devm_gpio_request_one
> can make the code simpler.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> Cc: Marek Vasut <marek.vasut@xxxxxxxxx>

Acked-by: Marek Vasut <marex@xxxxxxx>

> ---
>  drivers/video/backlight/lms283gf05.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/video/backlight/lms283gf05.c
> b/drivers/video/backlight/lms283gf05.c index ea43f22..c452210 100644
> --- a/drivers/video/backlight/lms283gf05.c
> +++ b/drivers/video/backlight/lms283gf05.c
> @@ -158,13 +158,9 @@ static int __devinit lms283gf05_probe(struct
> spi_device *spi) int ret = 0;
> 
>  	if (pdata != NULL) {
> -		ret = devm_gpio_request(&spi->dev, pdata->reset_gpio,
> -					"LMS285GF05 RESET");
> -		if (ret)
> -			return ret;
> -
> -		ret = gpio_direction_output(pdata->reset_gpio,
> -						!pdata->reset_inverted);
> +		ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
> +				GPIOF_DIR_OUT | !pdata->reset_inverted,
> +				"LMS285GF05 RESET");
>  		if (ret)
>  			return ret;
>  	}

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/