Re: [PATCH v4 6/6] perf stat: implement --big-num grouping

From: Christoph Hellwig
Date: Tue Oct 16 2012 - 12:49:21 EST


On Tue, Oct 16, 2012 at 02:33:40AM +0300, Irina Tirdea wrote:
> From: Irina Tirdea <irina.tirdea@xxxxxxxxx>
>
> In glibc, printf supports ' to group numbers with thousands' grouping
> characters. Bionic does not support ' for printf.
>
> Implement thousands's grouping for numbers according to locale.
> The implementation uses the algorithm from glibc
> (http://www.gnu.org/software/libc/).
>
> Bionic does not implement locales, so we need to add a configuration
> option LOCALE_SUPPORT. If it is not defined, default values for thousands
> separator and grouping are used.

Duplicating this in perf sounds like a hack. Does gnulib provide this
feature? It's the canonical source for getting standards or helper
functions on systems that don't support them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/