Re: [PATCH v4 3/6] perf tools: add --addr2line command line option

[Arnaldo Carvalho de Melo]

Em Tue, Oct 16, 2012 at 02:33:37AM +0300, Irina Tirdea escreveu:
> From: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> 
> When analyzing data recorded on a target with a different architecture
> than the host, we must use addr2line from the toolchain for that
> architecture.
> 
> Add a command line option to allow setting addr2line at runtime.

You're doing two things here:

1. Adding --addr2line

2. fixing a bug for unresolved symbols

Please try not to do that, instead provide two patches, one addressing
each issue.

Furthermore, Namhyung fixed #2 already:

commit a2c1311c4cbd47a087e95be18fee79ead3d0744b
Author: Namhyung Kim <namhyung.kim@xxxxxxx>
Date:   Mon Oct 15 12:39:42 2012 +0900

    perf tools: Fix segfault when using srcline sort key

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/