Re: Bisected regression in Linux 3.7.0-rc1, hang on login caused byreplace_fd()

From: Pavel Roskin
Date: Tue Oct 16 2012 - 11:02:47 EST


On Tue, 16 Oct 2012 00:48:53 +0100
Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Oct 15, 2012 at 07:40:08PM -0400, Pavel Roskin wrote:
> > On Tue, 16 Oct 2012 00:27:05 +0100
> > Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > > I think I understand what's going on there. Add
> > > fput(files[0]) after that replace_fd(); we have a leak and while
> > > that's not the right way to fix it, that'd verify if anything
> > > else is going on there.
> >
> > Yes, it's working now! No more hang on login!
>
> That should be closer to the final variant.

It works me, thank you! I don't use SELinux, so I could not really
test the second part.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/