Re: [PATCH v2] fat: editions to support fat_fallocate()

[OGAWA Hirofumi]

Namjae Jeon <linkinjeon@xxxxxxxxx> writes:

>> What is real usage pattern of persistent across remounts on FAT?
> Yes,  like a TORRENT FILE -> it reserves space in advance
> even though the system can be rebooted/disk unmounted and remount
> but the space still remains there - as long as the torrent exists
> Or if Torrent case does not matches currently
> Then, Consider a case for a TV series to be recorded
> Since â we want all the parts to be recorded on the same file (i.e.,
> APPEND write) â and in such cases there are chances of TV shutdown,
> device unmount-mount again. So, we need to have the space to be remain
> available in such cases.

The expectation of fallocate() is just for space reservation? If it was
just for space reservation, I'm not sure, why TV applications can't
reserve in userland without any kernel help (I wonder who interrupts TV
application). I feel a bit, it may be more lightweight than fallocate(),
and more reliable than out of spec fallocate().

I'm still not sure why apps really want fallocate() on FAT.

>> If once device was unmounted, we can't know the state of FS anymore, there are
>> many implementations of FAT. And preallocation is not in the spec.
> I agree, As you said before, we can make fat fallocate feature as
> configurable â so this is entirely in the hands of USER.
>>
>> I worry to break something. And I guess the freeing preallocation on
>> last close may fix the issue for usage.
> Okay, we can avoid most of your concerns except suddenly unplugging usb device.
> But fallocate behavior will be different with other filesystem.
>
> How about to make fat fallocate with configuration to be used by users
> is having needs?

Hmm... I'm not still convinced to add makes really apps happy. Maybe,
I'm sill not understanding your usage. I think the out of spec feature
wouldn't be added if it was just a "better than nothing".

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/