Re: [PATCH] cpufreq:core: Fix printing of governor and driver name
From: Viresh Kumar
Date: Mon Oct 15 2012 - 23:39:14 EST
On 15 October 2012 23:21, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Wednesday 10 of October 2012 10:12:11 Viresh Kumar wrote:
>> Arrays for governer and driver name are of size CPUFREQ_NAME_LEN or 16.
>> i.e. 15 bytes for name and 1 for trailing '\0'.
>>
>> When cpufreq driver print these names (for sysfs), it includes '\n' or ' ' in
>> the fmt string and still passes length as CPUFREQ_NAME_LEN. If the driver or
>> governor names are using all 15 fields allocated to them, then the trailing '\n'
>> or ' ' will never be printed. And so commands like:
>>
>> root@linaro-developer# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver
>>
>> will print something like:
>>
>> cpufreq_foodrvroot@linaro-developer#
>>
>> Fix this by increasing print length by one character.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> Thanks for the patch, I'll queue it up for v3.8.
Hi Rafael,
Thanks for accepting the patch.
I thought both of my patches would go in 3.7-rc2 as they are bug
fixes. Isn't that correct?
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/