Re: [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength

From: Peter Korsgaard
Date: Mon Oct 15 2012 - 14:56:36 EST


>>>>> Philip, Avinash <avinashphilip@xxxxxx> writes:

> Update number of errors using nand ecc strength.
> Also add macro definitions BCH8_ERROR_MAX & BCH4_ERROR_MAX

> Signed-off-by: Philip, Avinash <avinashphilip@xxxxxx>
> ---
> :100644 100644 5b31386... af511a9... M drivers/mtd/nand/omap2.c
> drivers/mtd/nand/omap2.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)

> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 5b31386..af511a9 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -111,6 +111,9 @@
> #define ECCCLEAR 0x100
> #define ECC1 0x1

> +#define BCH8_MAX_ERROR 8 /* upto 8 bit coorectable */
> +#define BCH4_MAX_ERROR 4 /* upto 4 bit correctable */

First 'correctable' misspelled.

I don't personally think these defines improve readability very much
compared to to just using 4/8, though.

--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/