Re: [PATCH 1/6] udf: fix memory leak while allocating blocksduring write
From: Jan Kara
Date: Thu Oct 11 2012 - 14:11:19 EST
On Wed 10-10-12 00:08:56, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>
> Need to brelse the buffer_head stored in cur_epos and next_epos.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Thanks. I've merged the patch.
Honza
> ---
> fs/udf/inode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index df88b95..2b77593 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -765,6 +765,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> goal, err);
> if (!newblocknum) {
> brelse(prev_epos.bh);
> + brelse(cur_epos.bh);
> + brelse(next_epos.bh);
> *err = -ENOSPC;
> return 0;
> }
> @@ -795,6 +797,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> udf_update_extents(inode, laarr, startnum, endnum, &prev_epos);
>
> brelse(prev_epos.bh);
> + brelse(cur_epos.bh);
> + brelse(next_epos.bh);
>
> newblock = udf_get_pblock(inode->i_sb, newblocknum,
> iinfo->i_location.partitionReferenceNum, 0);
> --
> 1.7.9.5
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/