Re: RE: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

[Heiko Schocher]

Hello Manjunathappa

On 11.10.2012 07:42, Manjunathappa, Prakash wrote:
> Hi,
> On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote:
> > From: Constantine Shulyupin<const@xxxxxxxxxxxxx>
> >
> > Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
> > CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
> > and set MUSB_OTG configuration by default
> > because this configuration options are removed from Kconfig.
> >
> > Signed-off-by: Constantine Shulyupin<const@xxxxxxxxxxxxx>
> >
> > ---
> >   arch/arm/mach-davinci/usb.c |    6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
> > index f77b953..34509ff 100644
> > --- a/arch/arm/mach-davinci/usb.c
> > +++ b/arch/arm/mach-davinci/usb.c
> > @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
> >   };
> >
> >   static struct musb_hdrc_platform_data usb_data = {
> > -#if defined(CONFIG_USB_MUSB_OTG)
> >   	/* OTG requires a Mini-AB connector */
> >   	.mode           = MUSB_OTG,
> > -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
> > -	.mode           = MUSB_PERIPHERAL,
> > -#elif defined(CONFIG_USB_MUSB_HOST)
> > -	.mode           = MUSB_HOST,
> > -#endif
> >   	.clock		= "usb",
> >   	.config		=&musb_config,
> >   };
>
> Tested it on DM6446-EVM for host mode with MSC thumb drive and gadget
> mode with g-ether. It works.
>
> Acked-by: Manjunathappa, Prakash<prakash.pm@xxxxxx>

I sent a similiar patch here:

http://comments.gmane.org/gmane.linux.usb.general/54512

If the issues, mentioned from Sergei for my patch, nullified I add my:

Acked-by: Heiko Schocher <hs@xxxxxxx>

for this patch.

bye,
Heiko
--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/