Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INETis disabled

[Glauber Costa]

On 10/11/2012 12:17 AM, David Rientjes wrote:
> On Wed, 10 Oct 2012, Fengguang Wu wrote:
> 
>>> Fengguang, was that this error? Why hasn't it showed up before in the
>>> test system?
>>
>> I do find this error in the build error log:
>>
>>         (.text+0x867f): undefined reference to `sock_update_memcg'
>>         2012-09-24 04:54:53 snb next:akpm:69921c3 x86_64-randconfig-s005 0a7f618
>>
>> Unfortunately it was not reported because the build system could
>> miss/ignore build bugs due to various reasons/imperfections. It has
>> since then undergo lots of enhancements and as a result, the daily
>> reported errors have more than doubled. :-)
>>
> 
> Not sure where this discussion is going.  Do people who can't build their 
> kernel and have a fix for it need to verify that your build system shows 
> the same thing first?  This isn't a false positive.
> 
> As I said in the first message, Randy reported this on September 24 (the 
> same date you're reporting above) and received no response when he 
> reported it to LKML here: 
> http://marc.info/?l=linux-kernel&m=134852557320089
> 
> Regardless, Linus' tree is messed up and I don't think we need to go back 
> reverting patches out of his tree when it's trivial to fix with my patch, 
> which Michal acked.  Sheesh.
> 
I am perfectly fine with your patch.

As I said when he first posted it: I see no reason to oppose cleanup
patches, as long as they don't break anything. Unfortunately it did, but
that is water under the bridge.

Again, since the goal of Michal patches was just to move things around,
I don't really care if you patch is applied or if Michal's is reverted.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/