RE: [PATCH 02/13] clk: davinci - add PSC clock driver

[Karicheri, Muralidharan]

>> -----Original Message-----
>> From: Nori, Sekhar
>> Sent: Wednesday, October 10, 2012 8:46 AM
>> To: Nori, Sekhar
>> Cc: Karicheri, Muralidharan; Hilman, Kevin; davinci-linux-open-
>> source@xxxxxxxxxxxxxxxxxxxx; mturquette@xxxxxxxxxx; linux-c6x-dev@xxxxxxxxxxxxx;
>> arnd@xxxxxxxx; linus.walleij@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> rob.herring@xxxxxxxxxxx; linux-keystone@xxxxxxxxxxx - Linux developers for Keystone
>> family of devices (May contain non-TIers); viresh.linux@xxxxxxxxx;
>> linux@xxxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; shawn.guo@xxxxxxxxxx; linux-arm-
>> kernel@xxxxxxxxxxxxxxxxxxx
>> Subject: Re: [PATCH 02/13] clk: davinci - add PSC clock driver
>> 
>> On 10/10/2012 6:05 PM, Sekhar Nori wrote:
>> 
>> >> +struct clk *clk_register_davinci_psc(struct device *dev, const char *name,
>> >> +			const char *parent_name,
>> >> +			struct clk_davinci_psc_data *psc_data,
>> >> +			spinlock_t *lock)
>> >
>> > Why do you need the lock to be provided from outside of this file? You
>> > can initialize a lock for serializing writes to PSC registers within
>> > this file, no?
>> 
>> Looking again, it seems like the common clock framework defines an "enable_lock" in
>> drivers/clk/clk.c to serialize the clock enable/disable calls. Unless I am missing something,
>> this lock seems unnecessary.
>> 

I think you are right. For enable() api, enable_lock is sufficient and I will remove this.

>> Thanks,
>> Sekhar
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_