Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue

From: Joe Perches
Date: Tue Oct 09 2012 - 12:22:11 EST


On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> Repalces printk's with pr_debug
[]
> diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> index 0ca857a..48fe622 100644
> --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
> static void wbsoft_remove_interface(struct ieee80211_hw *dev,
> struct ieee80211_vif *vif)
> {
> - printk("wbsoft_remove interface called\n");
> + pr_debug("wbsoft_remove interface called\n");

It'd be more consistent to use
pr_debug("%s called\n", __func__);
everywhere.

It might be even nicer to remove almost all of these.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/