Re: [PATCH V2 4/4] regulator: tps65090: add external control supportfor DCDC

From: Venu Byravarasu
Date: Tue Oct 09 2012 - 07:11:38 EST


On Tuesday 09 October 2012 03:32 PM, Laxman Dewangan wrote:
On Tuesday 09 October 2012 04:03 PM, Venu Byravarasu wrote:
+static struct regulator_ops tps65090_ext_control_ops = {
+};
What is the purpose of adding empty structure?

We will not able to register regulator if there is no ops.
In regulator register:
if (regulator_desc->name == NULL || regulator_desc->ops == NULL)
return ERR_PTR(-EINVAL);

If tps65090_ops would be left as is, without renaming it, hope this empty
structure can be removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/