Re: [ 110/180] ext4: dont let i_reserved_meta_blocks go negative

From: Willy Tarreau
Date: Sun Oct 07 2012 - 02:21:53 EST


On Sun, Oct 07, 2012 at 02:47:22AM +0100, Ben Hutchings wrote:
(...)
> > > This seems to be working around a bug elsewhere. Has the underlying
> > > bug been fixed in mainline yet?
> > >
> >
> > Yes, the bug was fixed in:
> >
> > 03179fe92318e7934c180d96f12eff2cb36ef7b6
> > ext4: undo ext4_calc_metadata_amount if we fail to claim space
>
> OK, and that's been applied to stable as:
>
> 3.2: d9af293 ext4: undo ext4_calc_metadata_amount if we fail to claim space
> 3.4: c0ce1fd ext4: undo ext4_calc_metadata_amount if we fail to claim space
> 3.5: 564dfa3 ext4: undo ext4_calc_metadata_amount if we fail to claim space
>
> Presumably it will need some backporting for older versions.

OK. I have checked the code, and it changed significantly since. I can
still see the logic there, but function names and calculations differ,
so I'd rather defer this patch for next version.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/