Re: [ 29/52] xHCI: add aborting command ring function

From: Ben Hutchings
Date: Sat Oct 06 2012 - 21:02:28 EST


On Thu, 2012-10-04 at 14:21 -0700, Greg Kroah-Hartman wrote:
[...]
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -52,7 +52,7 @@ MODULE_PARM_DESC(link_quirk, "Don't clea
> * handshake done). There are two failure modes: "usec" have passed (major
> * hardware flakeout), or the register reads as all-ones (hardware removed).
> */
> -static int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> +int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> u32 mask, u32 done, int usec)
> {
> u32 result;
[...]

I don't think it matters for stable, but since this function is now
extern it should have an 'xhci_' prefix.

Ben.

--
Ben Hutchings
You can't have everything. Where would you put it?

Attachment: signature.asc
Description: This is a digitally signed message part