Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

From: Alan Cox
Date: Fri Oct 05 2012 - 14:48:04 EST


> I have the same objection as before: using platform device solely for
> the purpose of passing some data from board code to the driver. Surely
> there are other ways of passing this bit of data... What about, for
> example, making it an empty weak symbol so that board code could
> override it with strong one?

I have the same objection to it being passed in other weird ways. This is
cross architecture, cross device stuff. Magic architecture goo and weak
symbols are not the right solution.

The reset switch is a device, physically and logically.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/