Re: [patch 1/2] mm: memcontrol: handle potential crash when rmapraces with task exit

From: Michal Hocko
Date: Fri Oct 05 2012 - 03:05:15 EST


On Thu 04-10-12 16:19:08, Johannes Weiner wrote:
> On Thu, Oct 04, 2012 at 08:49:58PM +0200, Michal Hocko wrote:
> > On Thu 04-10-12 14:09:16, Johannes Weiner wrote:
> > > page_referenced() counts only references of mm's that are associated
> > > with the memcg hierarchy that is being reclaimed. However, if it
> > > races with the owner of the mm exiting, mm->owner may be NULL. Don't
> > > crash, just ignore the reference.
> >
> > This seems to be fixed by Hugh's patch 3a981f48 "memcg: fix use_hierarchy
> > css_is_ancestor oops regression" which seems to be merged already.
>
> And look who acked the patch. I'll show myself out...

My memory is a bit fuzzy but I remember we had two alternatives and
Hugh's won.

--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/