Re: [PATCH v1] i2c-hid: introduce HID over i2c specificationimplementation

From: Jiri Kosina
Date: Thu Oct 04 2012 - 05:48:37 EST


On Thu, 4 Oct 2012, Benjamin Tissoires wrote:

> >> +
> >> + hid->claimed = 0;
> >
> > Should it be here and not in core?
>
> This is a line that was copied/pasted from usbhid. I'll check how can
> I do that without interfering with core.


Well, we are calling ll_driver->stop at multiple places, so having this
reset in the actual ll driver callback seems to be cleaner.

(if I understand the concern here correctly).

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/