Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), removefrom md

From: Hannes Reinecke
Date: Thu Oct 04 2012 - 02:07:16 EST


On 10/02/2012 10:11 PM, Kent Overstreet wrote:
On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote:
On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote:
Random cleanup - this code was duplicated and it's not really specific
to md.

Also added the ability to return the actual error code.

Who is going to make use of actual error code and why checking
BIO_UPTODATE is not sufficient (as existing code is doing)?

Some things do, though it's not common and I forget where I saw it -
checking for -ENOTSUPPORTED vs. other stuff

There are also additional error codes like -ENOLINK when the nexus is dropped. Quite useful in multipathed or clustered environs.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/