Re: [PATCH] Input: Add new driver into Input Subsystem for SynapticsDS4 touchscreen I2C devices

From: Henrik Rydberg
Date: Wed Oct 03 2012 - 14:00:40 EST


Hi Alexandra,

> Hi Henrik/Dmitry,
>
> We are working on a product specific driver for Synaptics DS4 I2C touchscreen
> devices. It was submitted on Sept. 16, 2012, but has not been reviewed.
> (http://lkml.org/lkml/2012/9/16/24).
> We found several warnings after running script/checkpatch.pl, therefore
> an updated patch is attached.
>
> As Chris says in https://lkml.org/lkml/2012/9/19/505, this driver will enable
> us to support all our customers effectively and provide our customers with
> the best flexibility possible.
> Please help review attached patch, and we really appreciate your feedback :-)

It seems this driver is already present in staging. Comments and
formatting have been improved in the staging version, but that aside,
the two versions look very similar. Why don't you submit fixes to
that driver instead?

On a general note, both versions of the driver use MT-A. Please
convert to MT-B, using the in-kernel tracking if necessary.

Thanks.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/