Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fixthe probe

From: Fabio Estevam
Date: Wed Oct 03 2012 - 12:21:26 EST


On Mon, Oct 1, 2012 at 7:22 AM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 28, 2012 at 05:34:18PM -0300, Fabio Estevam wrote:
>
>> +static struct irq_chip da9052_irq_chip = {
>> + .name = "da9052",
>> + .irq_disable = da9052_irq_disable,
>> + .irq_enable = da9052_irq_enable,
>> +};
>
> I don't understand what this irq_chip or the custom domain you're adding
> are for?

I declared da9052_irq_chip because I do the following:

irq_set_chip_and_handler(virq, &da9052_irq_chip, handle_level_irq);

I am following the arizona-irq approach.

If this is not suitable, can you please point me to some driver that
does not define irq_chip and can still do setup
"irq_set_chip_and_handler()"?

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/