Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region

From: Lukáš Czerner
Date: Wed Oct 03 2012 - 09:47:11 EST


On Wed, 5 Sep 2012, Douglas Gilbert wrote:

> Date: Wed, 05 Sep 2012 15:41:13 -0400
> From: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
> To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx,
> JBottomley@xxxxxxxxxxxxx, tytso@xxxxxxx, pbonzini@xxxxxxxxxx,
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region
>
> On 12-08-17 12:11 PM, Martin K. Petersen wrote:
> > > > > > > "Lukas" == Lukas Czerner <lczerner@xxxxxxxxxx> writes:
> >
> > Lukas> Currently it is possible to unmap one more block than user
> > Lukas> requested to due to the off-by-one error in unmap_region(). This
> > Lukas> is probably due to the fact that the end variable despite its
> > Lukas> name actually points to the last block to unmap + 1. However in
> > Lukas> the condition it is handled as the last block of the region to
> > Lukas> unmap.
> >
> > Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>
> Acked-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>

James, could you please pick this one ?

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/