Re: [PATCH 08/17] ARM: at91: unused variable inat91_pm_verify_clocks

From: Jean-Christophe PLAGNIOL-VILLARD
Date: Tue Oct 02 2012 - 15:22:16 EST


On 18:36 Tue 02 Oct , Arnd Bergmann wrote:
> The code using the variable 'i' in this function is conditional, so
> we have to make the declaration conditional as well to avoid a harmless
> warning.
>
> Without this patch, building at91sam9263_defconfig results in:
>
> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c: In function 'at91_pm_verify_clocks':
> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c:137:6: warning: unused variable 'i' [-Wunused-variable]
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> ---
> arch/arm/mach-at91/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 2c2d865..cdd620d 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -135,7 +135,9 @@ static int at91_pm_begin(suspend_state_t state)
> static int at91_pm_verify_clocks(void)
> {
> unsigned long scsr;
> +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS
> int i;
> +#endif
please is if (IS_ENBLED())

#ifdef drop code coverage

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/