Re: [PATCH] ACPI: Add new sysfs interface to export device description

From: Len Brown
Date: Tue Oct 02 2012 - 00:14:39 EST


>
> To address your comment, I was trying to differentiate between the existence of the _STR method and the failure to evaluate it.
> If an STR method exists, we create the sysfs file. If it fails to
evaluate, we will see "No Description" when we read the file.
> This would indicate that something is wrong as opposed to the system not having an _STR.
> If you feel that this is unnecessary, or should be done differently let me know.

This patch looks useful, and I this does seem like a logical place
to export this information.

however, I'd think that an empty attribute instead of "No description"
is sufficient to cover the case of _STR existing, but for some reason
failing to evaluate.

thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/