Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macromodule_platform_driver()

From: Andy Shevchenko
Date: Mon Oct 01 2012 - 06:47:33 EST


On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote:
> On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote:
> > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> >
>
> commit log would be great.
Will do.

> > static struct platform_driver dw_driver = {
> > + .probe = dw_probe,
>
> probe's in __init section. This is wrong. You need to change probe
> __devinit.
Have you checked this one
0272e93f364eac1a30f2831adcaca3dd633d5f14

Or might be I missed something?


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/