Re: [PATCH 04/16] iommu/amd: Check if IOAPIC information is correct

From: Joerg Roedel
Date: Fri Sep 28 2012 - 10:37:21 EST


On Fri, Sep 28, 2012 at 10:16:45AM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 28, 2012 at 02:23:54PM +0200, Joerg Roedel wrote:
> +static bool __init check_ioapic_information(void)
> > +{
> > + int idx;
> > +
> > + for (idx = 0; idx < nr_ioapics; ++idx) {
>
> That ++idx looks odd - and it looks like the file has a combination of
> i++ and ++i. Any particular reason for using this particular one instead
> of the more common: "idx++" ? Or just habit?

Well, it's just a habbit from my time with C++ :)

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/