Re: [PATCH] mfd: da9052-core: Fix request_threaded_irq() parameter

[Mark Brown]

On Thu, Sep 27, 2012 at 12:55:35AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> On a mx53qsb dt-kernel the da9052-core driver fails to probe:
> 
> da9052 1-0048: DA9052 ADC IRQ failed ret=-22
> 
> In request_threaded_irq() the first parameter is missing the da9052->irq_base.
> 
> Fix it and avoid the error.

The driver shouldn't be relying on irq_base at all, it should use
regmap_get_virq() to look up the interrupt number.  If it relies on
irq_base then the user is forced to assign one (or rely on automatic
assignment, which is a bit erratic.  Otherwise it can use a linear
domain which doesn't rely on being able to allocate a big block of
interrupt numbers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/