Re: [PATCH 1/8] sta2x11-mfd : add apb-soc regs driver and factor outcommon code

From: Mark Brown
Date: Thu Sep 27 2012 - 09:49:20 EST


On Thu, Sep 27, 2012 at 03:41:10PM +0200, Davide Ciminaghi wrote:

> Maybe there's another solution: what about adding a couple of function
> pointers (lock, unlock) to struct regmap_config ? If they're set to NULL,
> everything works as usual. If they're not NULL, regmap uses such functions
> to do locking and unlocking instead of the usual ones (and regmap_bus.fast_io
> is ignored). I think this wouldn't hurt existing regmap users and allow
> sta2x11-mfd to have just one spinlock for everything, no need for nested
> locking this way.

That might work, yes, and would be generally useful I think. Or we
could add regmap based versions of the clock utilities (which would also
be useful anyway). Or both.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/