Re: [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation

[Andy Shevchenko]

On Thu, Sep 27, 2012 at 11:19 AM, viresh kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On Thu, Sep 27, 2012 at 1:15 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>> On Thu, Sep 27, 2012 at 10:31:58AM +0300, Andy Shevchenko wrote:
>>> From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>>>
>>> The driver will be used as a core part for various implementations of the
>>> DesignWare DMA device. The patch adjusts description on the top and corrects
>>> paragraph indentation in few places across the code.
>>>
>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>> ---
>>>  drivers/dma/dw_dmac.c |    7 ++++---
>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>>> index bbb2a82..9f0129d 100644
>>> --- a/drivers/dma/dw_dmac.c
>>> +++ b/drivers/dma/dw_dmac.c
>>> @@ -1,14 +1,15 @@
>>>  /*
>>> - * Driver for the Synopsys DesignWare DMA Controller (aka DMACA on
>>> - * AVR32 systems.)
>>> + * Core driver for the Synopsys DesignWare DMA Controller
>>>   *
>>>   * Copyright (C) 2007-2008 Atmel Corporation
>>>   * Copyright (C) 2010-2011 ST Microelectronics
>>> + * Copyright (C) 2012 Intel Corporation
>>
>> I'm not a lawyer, but I'm not sure the few changes done to this driver
>> is enough for Intel to hold a copyright here... dunno, though.
>
> Neither do i :)
I only have one precedent where was a collision between two versions
of the as3645a driver.
In the result Nokia's version was modified accordingly to my comments
and few patches.

> @Vinod: Can we have some inputs from you here?
Agree, it's good to have an additional opinion here.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/