Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

From: OGAWA Hirofumi
Date: Mon Sep 24 2012 - 06:57:48 EST


Namjae Jeon <linkinjeon@xxxxxxxxx> writes:

>> I see. fileid seems to be stat.ino on nfsd4. inode->i_ino is actually
>> just a hash key of inode hash (exception is only in audit, iirc).
>>
>> So, what happens if we set "stat->ino = i_pos" on fat_getattr().
>>
>> int fat_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat
>> *stat)
>> {
>> struct inode *inode = dentry->d_inode;
>> generic_fillattr(inode, stat);
>> stat->blksize = MSDOS_SB(inode->i_sb)->cluster_size;
>> if (opts->nfs == FAT_NFS_LIMITED) {
>> /* Use i_pos for ino. This is used as fileid of nfs. */
>> stat->ino = MSDOS_SB(inode->i_sb)->i_pos;

stat->ino = fat_i_pos_read(MSDOS_SB(inode->i_sb), inode);

Ouch, I forgot to use fat_i_pos_read().

>> }
>> return 0;
>> }
> Okay, Thanks for your help.
> I will share the result after checking.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/