Re: [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8

From: Rabin Vincent
Date: Sun Sep 23 2012 - 10:19:56 EST


2012/8/3 George Spelvin <linux@xxxxxxxxxxx>:
> If you're going to have a conditional branch after
> each 32x32->64-bit multiply, might as well shrink the code
> and make it a loop.
>
> This also avoids using the long multiply for small integers.
>
> (This leaves the comments in a confusing state, but that's a separate
> patch to make review easier.)
>
> Signed-off-by: George Spelvin <linux@xxxxxxxxxxx>

This patch breaks IP address printing with "%pI4" (and by extension,
nfsroot). Example:

- Before: 10.0.0.1
- After: 10...1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/