Re: [patch net] sky2: fix rx filter setup on link up

From: Stephen Hemminger
Date: Sat Sep 22 2012 - 16:15:10 EST


On Mon, 17 Sep 2012 17:10:17 +0200
Jiri Pirko <jiri@xxxxxxxxxxx> wrote:

> + sky2_write_rx_filter(sky2, filter);
> + memcpy(sky2->rx_filter, filter, sizeof(sky2->rx_filter));

This isn't safe since rx_filter might be referred to from interrupt
context (ie link up PHY interrupt). Maybe using atomic64 would be
best.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/