Re: [PATCH v2 5/5] ARM: tegra: enable brcmfmac in defconfig

From: Stephen Warren
Date: Fri Sep 21 2012 - 12:19:41 EST


On 09/21/2012 08:39 AM, Arend van Spriel wrote:
> On 09/21/2012 10:55 AM, Wei Ni wrote:
>> New options enabled:
>> * CFG80211_WEXT: (dependency)
>> * BRCMFMAC: wlan driver, enable as module.
>>
>> Signed-off-by: Wei Ni <wni@xxxxxxxxxx>
>> ---
>> arch/arm/configs/tegra_defconfig | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/configs/tegra_defconfig
>> b/arch/arm/configs/tegra_defconfig
>> index adcf3c2..04b18ea 100644
>> --- a/arch/arm/configs/tegra_defconfig
>> +++ b/arch/arm/configs/tegra_defconfig
>> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>> CONFIG_BT_HIDP=y
>> CONFIG_BT_HCIBTUSB=m
>> CONFIG_CFG80211=y
>> +CONFIG_CFG80211_WEXT=y
>
> Any particular reason for enabling this? The driver does not
> specifically need it. The option only allows use of WEXT dependent
> user-space tools like iwconfig and iwlist. At least it is not needed by
> brcmfmac driver hence it does not select it.
>
> You indicate there is a dependency. Could you elaborate?

"Dependency" probably isn't correct.

However, the intent of tegra_defconfig is to provide a useful
configuration for Tegra boards. Without the ability to use
iwconfig/iwlist, enabling the wireless driver doesn't seem useful; how
would someone configure the wireless connection?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/