Re: [PATCH] ipconfig: add nameserver IPs to kernel-parameter ip=

From: David Miller
Date: Thu Sep 20 2012 - 17:37:14 EST


From: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
Date: Thu, 20 Sep 2012 23:28:05 +0200

> + pr_info(" nameserver%u=%pI4",
> + i, &ic_nameservers[i]);

Why don't you just tab that second line out to planet Mars while
you're at it?

Please format this correctly, the goal is not to use a million
TAB characters. Rather, the goal is to get the text starting
on the second line of a function call to line up with the
first column after the openning parenthesis on the previous line.

What you're doing there looks awful, so you'll need to fix this
up before this patch will be considered seriously.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/