Re: [RFC PATCH] perf tool: Add a global variable "const char*input_name"

[Arnaldo Carvalho de Melo]

Em Thu, Sep 20, 2012 at 10:19:39PM +0800, Feng Tang escreveu:
> Currently many perf ommands annotate/evlist/report/script/lock etc
> all support "-i" option to chose a specific perf data, and all
> of them create a local "input_name" to save the file name for
> that perf data.
> 
> So adding a global variable could unify all those local ones, and
> it will also be useful for other codes which need to know the file name.

But I think the input_name should be passed as a parameter to whoever
needs it. Think about 'perf diff', for instance, it deals with two
perf.data files.

In general I think we should _remove_ more globals :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/