Re: [PATCH 01/25] userns: Convert fat to use kuid/kgid where appropriate

[OGAWA Hirofumi]

ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes:

>> I'm not reading this thread, so I may be wrong though. Doesn't this need
>> to initialize opts->fs_uid/fs_gid by GLOBAL_ROOT_UID/GID?
>
> Good question.
>
> At the start of parse_options there is:
>
> static int parse_options(struct super_block *sb, char *options, int is_vfat,
> 			 int silent, int *debug, struct fat_mount_options *opts)
> {
> 	char *p;
> 	substring_t args[MAX_OPT_ARGS];
> 	int option;
> 	char *iocharset;
>
> 	opts->isvfat = is_vfat;
>
> 	opts->fs_uid = current_uid();
> 	opts->fs_gid = current_gid();
>
> So there should be no problems with initialization.

I see.

Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/