Re: [PATCH 1/4] perf header: Add struct perf_header_info

[Arnaldo Carvalho de Melo]

Em Thu, Sep 20, 2012 at 02:36:44PM +0900, Namhyung Kim escreveu:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
> 
> The struct perf_header_info will preserve environment information at
> the time of perf record.  It can be accessed anytime after parsing a
> perf.data file if needed.
 
> +struct perf_header_info {

I think it would be better named as 'perf_session_env' i.e. the
environment (machine (name), hardware(nr_cpus, total_mem, etc) and
OS(release, version) details) where a 'perf' 'session' took place.

perf 'header info' look more like 'what is the version in the header?
what about its endianity, and other 'header' details :-)

> +	char			*hostname;
> +	char			*os_release;
> +	char			*version;
> +	char			*arch;
> +	int			nr_cpus_online;
> +	int			nr_cpus_avail;
> +	char			*cpu_desc;
> +	char			*cpuid;
> +	unsigned long long	total_mem;
> +
> +	int			nr_cmdline;
> +	char			*cmdline;
> +	int			nr_sibling_cores;
> +	char			*sibling_cores;
> +	int			nr_sibling_threads;
> +	char			*sibling_threads;
> +	int			nr_numa_nodes;
> +	char			*numa_nodes;
> +	int			nr_pmu_mappings;
> +	char			*pmu_mappings;
> +};
> +
>  struct perf_header {
>  	int			frozen;
>  	bool			needs_swap;
> @@ -67,6 +90,7 @@ struct perf_header {
>  	u64			event_offset;
>  	u64			event_size;
>  	DECLARE_BITMAP(adds_features, HEADER_FEAT_BITS);
> +	struct perf_header_info info;
>  };
>  
>  struct perf_evlist;
> -- 
> 1.7.11.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/