RE: [PATCHv3] remoteproc: Add STE modem driver for remoteproc

[Sjur BRENDELAND]

Hi Ohad,

> > +       /* Provide callbacks to modem device */
> > +       mdev->drv_ops = &sproc_drv_ops;
> 
> Implicitly providing the modem with drv_ops and drv_data in this
> manner feels racy and somewhat error prone.
> 
> E.g., on remove these members are set to NULL, under the assumption
> that the modem won't invoke sproc_kick_callback or access sproc
> anymore, but this doesn't feel safe.
> 
> Any chance you can add an explicit registration method to
> ste_modem_dev_ops, with which you'll be able to explicitly set/unset
> sproc_kick_callback and sproc ?

Good point. I'll make a respin fixing this.

Thanks,
Sjur
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/