Re: [PATCH 2/7] dw_dmac: fill optional encoded parameters in register structure

From: Andy Shevchenko
Date: Thu Sep 20 2012 - 05:51:53 EST


On Thu, Sep 20, 2012 at 12:32 PM, viresh kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On Thu, Sep 20, 2012 at 3:00 PM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> Ok. If i am not wrong, such calls are only required once for below line:
>> Actually twice...
>>> dw_params = dma_raw_readl(regs, DW_PARAMS
>> ...here and for channel parameters.
>
> Till the time we hit channel code, we can allocate memory for dw and so
> can use dma_readl/writel. Isn't it?
Actually no. Becase we have the same name for 8 registers.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/