Re: [PATCH 1/1] audit: Use a tracepoint for getname

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:

> Al, Eric,
> 
> 	Was this considered before? Acceptable?
> 
> - Arnaldo
> 
> ---
> 
> Instead of an explicit hook only for audit, use a tracepoint, so that
> other users that need to know about filenames can hook there just like
> audit.
> 
> Based on an earlier patch by Thomas Gleixner that added the tracepoint
> but left the audit_getname call.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>  fs/namei.c                 |    5 ++++-
>  include/linux/audit.h      |    6 +-----
>  include/trace/events/vfs.h |   32 ++++++++++++++++++++++++++++++++
>  init/Kconfig               |    2 +-
>  kernel/audit.c             |   11 +++++++++++
>  5 files changed, 49 insertions(+), 7 deletions(-)
>  create mode 100644 include/trace/events/vfs.h

Nice generalization and we gain a useful tracepoint as well.

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/