Re: [PATCH] mfd: use IRQF_ONESHOT for twl6040

[Peter Ujfalusi]

On 09/19/2012 04:32 AM, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> 
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT.
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  drivers/mfd/twl6040-core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux.orig/drivers/mfd/twl6040-core.c	2012-09-18 08:22:36.381180459 +0800
> +++ linux/drivers/mfd/twl6040-core.c	2012-09-19 09:27:15.947969313 +0800
> @@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc
>  		goto irq_init_err;
>  
>  	ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY,
> -				   NULL, twl6040_naudint_handler, 0,
> +				   NULL, twl6040_naudint_handler, IRQF_ONESHOT,
>  				   "twl6040_irq_ready", twl6040);
>  	if (ret) {
>  		dev_err(twl6040->dev, "READY IRQ request failed: %d\n",
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/