Re: [PATCH] poweroff: fix bug in orderly_poweroff

[Kees Cook]

On Tue, Sep 18, 2012 at 8:27 PM, hongfeng <hongfeng@xxxxxxxxxxx> wrote:
> orderly_poweroff is trying to poweroff platform by two steps:
> step 1: Call userspace application to poweroff
> step 2: If userspace poweroff fail, then do a force power off if force param is set.
>
> The bug here is, step 1 is always successful with param UMH_NO_WAIT,
> should change to UMH_WAIT_PROC which will monitor the return value ofuserspace application.
>
> Signed-off-by: Feng Hong <hongfeng@xxxxxxxxxxx>

Seems right to me.

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/