RE: [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code

[Bounine, Alexandre]

On Monday, Sep.17, at 2012 4:14 AM Peter Senna Tschudin wrote:
> 
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
> 
... skip ...
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
> ---
>  drivers/rapidio/devices/tsi721.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rapidio/devices/tsi721.c
> b/drivers/rapidio/devices/tsi721.c
> index 1974359..78dff6f 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -2316,7 +2316,8 @@ static int __devinit tsi721_probe(struct pci_dev
> *pdev,
> 
>  	/* Configure DMA attributes. */
>  	if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
> -		if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
> +		err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> +		if (err) {
>  			dev_info(&pdev->dev, "Unable to set DMA mask\n");
>  			goto err_unmap_bars;
>  		}
> --
> 1.7.11.4

Acked-by: Alexandre Bounine <alexandre.bounine@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/