Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter viadevice_prep_dma_cyclic() callback

[Vinod Koul]

On Tue, 2012-09-18 at 09:31 +0100, Russell King - ARM Linux wrote:
> On Mon, Sep 17, 2012 at 11:01:23AM +0200, Linus Walleij wrote:
> > On Thu, Sep 13, 2012 at 3:37 PM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:
> > 
> > > Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
> > > can receive the no_wakeup request coming from client drivers.
> > > This feature can be used during audio operation to disable all audio
> > > related interrupts.
> > >
> > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> > > CC: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> > > CC: Barry Song <baohua.song@xxxxxxx>
> > > CC: Srinidhi Kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx>
> > > CC: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
> > > CC: Vista Silicon <javier.martin@xxxxxxxxxxxxxxxxx>
> > > CC: Zhangfei Gao <zhangfei.gao@xxxxxxxxxxx>
> > > CC: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > > CC: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > 
> > After some discussion with clever people I know I have come to the conclusion
> > that this is a good idea, so:
> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> NAKed-by: me
> 
> If you look at the other sub-threads of the patch you're acking, you'll
> notice that there's a v3 of this patch set which changes the way this is
> done.
Was it a genuine mistake, think v3 reply v2? Or less caffeine..... :)


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/