Re: [PATCH 0/7] dw_dmac: introduce autoconfiguration

[Hein Tibosch]

On 9/17/2012 3:39 PM, Andy Shevchenko wrote:
> Here is a patchset that allows to adapt the driver to the hardware
> configuration during probe time. The hardware should have the specific optional
> parameters enabled. Otherwise the driver will consider values stored in the
> platform data.
>
> Additionally it brings support of the software LLP transfers. It means that
> normal linked list transfer is substituted by set of single block transfers
> transparently to the user.
>
> Comments are welcome.
>
> Andy Shevchenko (7):
>   dw_dmac: mark dwc_dump_chan_regs as inline
>   dw_dmac: fill optional encoded parameters in register structure
>   dw_dmac: get number of channels from hardware if possible
>   dw_dmac: autoconfigure block_size or use platform data
>   dw_dmac: autoconfigure data_width or get it via platform data
>   dw_dmac: check if controller supports LLP
>   dw_dmac: introduce software emulation of LLP transfers
>
>  arch/arm/mach-spear13xx/spear13xx.c |    3 +
>  arch/avr32/mach-at32ap/at32ap700x.c |    3 +
>  drivers/dma/dw_dmac.c               |  207 +++++++++++++++++++++++++++++------
>  drivers/dma/dw_dmac_regs.h          |   48 ++++++++
>  include/linux/dw_dmac.h             |    7 ++
>  5 files changed, 235 insertions(+), 33 deletions(-)
Andy,

The (embedded) dw dma on the AP7000 indeed does not support auto
configuration (the register reads as zero) and so it needs the
platform data.

I tested the driver on AVR32 with the atmel-mci driver and it all
worked well.

I also tested the new software emulation of LLP mode by setting
nollp for each channel to true. That also worked as expected.


Tested-by: Hein Tibosch <hein_tibosch@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/