Re: [PATCH] pci: rewrite pci_call_probe() to use workqueue instead of work_on_cpu()

[Bjorn Helgaas]

On Mon, Sep 17, 2012 at 3:41 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> On Fri, Sep 14, 2012 at 12:13:21PM -0600, Bjorn Helgaas wrote:
>> On Thu, Aug 23, 2012 at 3:35 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> > pci_call_probe() uses work_on_cpu(), which creates and tears down a
>> > full kthread on each call, to invoke ->probe() on node local CPU for
>> > allocation affinity.
>> >
>> > The same goal can easily be achieved using a work item.  This patch
>> > rewrites pci_call_probe() so that it uses a work item instead of
>> > work_on_cpu().
>> >
>> > Note that the function is restructured for simplicity.  This adds
>> > get/put_online_cpus() pair for devices without node but the overhead
>> > of doing so isn't anything material at this level.
>> >
>> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>>
>> I applied this to my "next" branch and pushed it.  Thanks!
>
> Can you please drop / revert this one?  It seems we need work_on_cpu()
> after all and I'm gonna reimplement it in sane way.

I dropped it.  Thanks for the heads-up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/